[PATCH] D49764: Simplify ObjFile::createDefined().
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 24 15:44:33 PDT 2018
pcc added inline comments.
================
Comment at: lld/COFF/InputFiles.cpp:264
// 2) symbol belongs to a comdat section associated with a section whose
// section definition symbol appears later in the symbol table.
// In both of these cases, we can expect the section to be resolved by
----------------
With this change, this comment is no longer accurate. I believe that we now add all symbols in associative sections to the pending list.
================
Comment at: lld/COFF/InputFiles.cpp:277
if (Def->Selection == IMAGE_COMDAT_SELECT_ASSOCIATIVE)
readAssociativeDefinition(Sym, Def);
Symbols[I] = createRegular(Sym);
----------------
Since this is now the only caller you could inline the body here.
https://reviews.llvm.org/D49764
More information about the llvm-commits
mailing list