[PATCH] D49522: [DWARF v5] Don't emit duplicate DW_AT_rnglists_base and address review comments from previous review

Wolfgang Pieb via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 15:34:11 PDT 2018


wolfgangp added a comment.

In https://reviews.llvm.org/D49522#1172894, @dblaikie wrote:

> Is this still missing test coverage for the case where the CU has low/high_pc, but also needs a ranges_base because a function has ranges for a local scope? Looks like the bug got fixed, but test coverage is still missing?


This case is covered by the modified fission-range.ll in https://reviews.llvm.org/D49214. It's technically not a fission test case, but it was a convenient place to put it. I can pull it out if you like, or perhaps add a simpler test case.


https://reviews.llvm.org/D49522





More information about the llvm-commits mailing list