[PATCH] D49700: [LLD] [COFF] Treat .xdata/.pdata$<sym> as implicitly associative to <sym> for MinGW

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D49700#1174123, @ruiu wrote:

> `initializeSymbols` and `createDefined` were originally much simpler than they are now. They are becoming complicated gradually over time. Due to the length of these functions (they are a bit too long to my taste) and the lack of comments (for example, what does `Prevailing` means?), they are probably hard to read for newcomers. Can you simplify the code and add an explanation as a comment before adding more code there? I believe the code can be improved.


I'm not sure if I'm up to trying to simplify the existing code (if possible) or add comments on how it works (I have no idea about most if it, I hadn't seen it until two days ago), and that sounds like a too loosely defined task, that easily ends up as impossible to properly complete, blocking this patch indefinitely.

But I could try to add more verbose comments to the new code I'm adding at least.


https://reviews.llvm.org/D49700