[PATCH] D49753: [windows] Don't inline fieldFromInstruction on Windows

[Zachary Turner via llvm-commits]

I don’t use the vs generator and I don’t explicitly pass enable assertions
= off (isn’t that the default for release builds)? I do build release
builds with no debug info though.

Note that clang-cl probably doesn’t have this bug, so the check should
probably be _MSC_VER && !__clang__
On Tue, Jul 24, 2018 at 1:34 PM Stella Stamenova via Phabricator <
reviews at reviews.llvm.org> wrote:

> stella.stamenova added a comment.
>
> I don't know if it impacts all shipping versions since we only test with
> the latest versions. I would suspect that you either build with assertions
> set to ON or you include debug information when you build. Here's the CMAKE
> command line that reproduces this:
>
> -DCMAKE_BUILD_TYPE=Release -G "Visual Studio 15 2017 Win64" -Thost=x64
> -DLLVM_ENABLE_ASSERTIONS=OFF
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D49753
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180724/8d3e8386/attachment.html>