[PATCH] D49751: Add maybe-unused attribute to a variable.

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 13:37:00 PDT 2018


nickdesaulniers added inline comments.


================
Comment at: lib/IR/SafepointIRVerifier.cpp:87
     const BasicBlock* BB = PN->getParent();
+    [[maybe_unused]]
     bool Listed = false;
----------------
srhines wrote:
> Did you run clang-format on this? I think it belongs on the same line for LLVM coding style.
Running `$ clang-format -i lib/IR/SafepointIRVerifier.cpp` makes quite a few changes to this file (and puts the attribute on the same line). Is that ok?  I assume clang-format can find the `.clang-format` in the top of the tree (using the LLVM style, as opposed to whatever the defaults are)?


Repository:
  rL LLVM

https://reviews.llvm.org/D49751





More information about the llvm-commits mailing list