[PATCH] D49717: [x86] Teach the x86 backend that it can fold between TCRETURNm* and TCRETURNr* and fix latent bugs with register class updates.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 10:57:57 PDT 2018


chandlerc added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:4662
+
+  for (int Idx : llvm::seq<int>(0, NewMI.getNumOperands())) {
+    MachineOperand &MO = NewMI.getOperand(Idx);
----------------
craig.topper wrote:
> This is cute and all, but why not a normal integer for loop?
I find it shorter and more clear (you can look at the review for Sequence.h for other commentary there). If it bothers folks, I can remove it, I just routinely use it in new code.


Repository:
  rL LLVM

https://reviews.llvm.org/D49717





More information about the llvm-commits mailing list