[PATCH] D49672: [CMake] Honor LLVM_EXTERNAL_<proj>_SOURCE_DIR
David Greene via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jul 24 09:12:42 PDT 2018
greened added a comment.
In https://reviews.llvm.org/D49672#1172588, @chapuni wrote:
> I expect LLVM_EXTERNAL_*_SOURCE_DIR will work if LLVM_ENABLE_PROJECT doesn't include one.
I am not sure what you mean. Are you saying that with LLVM_EXTERNAL_*_SOURCE_DIR set, the component doesn't need to be in LLVM_ENABLE_PROJECT? That was not my experience. I had to set both to get a build to include the components. It was not enough
to just set LLVM_EXTERNAL_*_SOURCE_DIR.
I see that the documentation says that LLVM_EXTERNAL_*_SOURCE_DIR should be sufficient. Perhaps I did something wrong. The
documentation also says that LLVM_ENABLE_PROJECT assumes the projects are checked out side-by-side. Let me play with
this a bit and see if I can get things to work without this patch.
Repository:
rL LLVM
https://reviews.llvm.org/D49672
More information about the llvm-commits
mailing list