[PATCH] D49730: Don't filter test-critical calls out of xray data

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 24 07:40:28 PDT 2018


jmorse created this revision.
jmorse added reviewers: dberris, Maknee.
Herald added subscribers: Sanitizers, llvm-commits.

By default, xray filters events that takes less than 5uS from its log.
In this existing test, should printf complete very quickly this will
lead to test-critical function-calls being filtered (i.e. print_parent_tid).
Given that we're not testing the filtering feature, disable it for this
test.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49730

Files:
  test/xray/TestCases/Posix/fork_basic_logging.cc


Index: test/xray/TestCases/Posix/fork_basic_logging.cc
===================================================================
--- test/xray/TestCases/Posix/fork_basic_logging.cc
+++ test/xray/TestCases/Posix/fork_basic_logging.cc
@@ -2,7 +2,7 @@
 // RUN: %clangxx_xray -g -std=c++11 %s -o %t
 // RUN: rm -f fork-basic-logging-test-*
 // RUN: XRAY_OPTIONS="patch_premain=true xray_logfile_base=fork-basic-logging-test- \
-// RUN:     xray_mode=xray-basic verbosity=1" \
+// RUN:     xray_mode=xray-basic verbosity=1 xray_naive_log_func_duration_threshold_us=0" \
 // RUN:     %run %t 2>&1 | FileCheck %s
 // RUN: %llvm_xray convert --symbolize --output-format=yaml -instr_map=%t \
 // RUN:     "`ls -S fork-basic-logging-test-* | head -1`" \


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49730.157027.patch
Type: text/x-patch
Size: 738 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180724/19f4686b/attachment.bin>


More information about the llvm-commits mailing list