[PATCH] D49653: [LLD] [COFF] Handle comdat sections without leader symbols

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: COFF/InputFiles.cpp:289
         readAssociativeDefinition(Sym, Def);
     Symbols[I] = createRegular(Sym);
   }
----------------
rnk wrote:
> I think this is probably the right place to do the check.
Yes, this is the one place where `createRegular` is called without checking for `PendingComdat` before. I thought the check felt natural there, but I can move it here instead.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49653