[PATCH] D49687: llvm-xray: Broken chrome trace event format output

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 18:45:59 PDT 2018


This revision was automatically updated to reflect the committed changes.
Closed by commit rL337795: llvm-xray: Broken chrome trace event format output (authored by dberris, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D49687?vs=156840&id=156955#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D49687

Files:
  llvm/trunk/tools/llvm-xray/xray-converter.cpp


Index: llvm/trunk/tools/llvm-xray/xray-converter.cpp
===================================================================
--- llvm/trunk/tools/llvm-xray/xray-converter.cpp
+++ llvm/trunk/tools/llvm-xray/xray-converter.cpp
@@ -313,6 +313,9 @@
       // (And/Or in loop termination below)
       StackTrieNode *PreviousCursor = nullptr;
       do {
+        if (PreviousCursor != nullptr) {
+          OS << ",\n";
+        }
         writeTraceViewerRecord(Version, OS, StackCursor->FuncId, R.TId, R.PId,
                                Symbolize, FuncIdHelper, EventTimestampUs,
                                *StackCursor, "E");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49687.156955.patch
Type: text/x-patch
Size: 630 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180724/7967f719/attachment.bin>


More information about the llvm-commits mailing list