[PATCH] D47217: [cmake] [ARM] Exclude any VFP builtins if VFP is not supported

[Azharuddin Mohammed via Phabricator via llvm-commits]

azharudd added a comment.

In https://reviews.llvm.org/D47217#1165279, @peter.smith wrote:

> Can you elaborate on why the armhf buildbot failed and why you have excluded armhf from the MATCHES expression above. A simple test of a source file containing
>
>   __VFP_FP__
>
>
> clang --target=arm-linux-gnueabihf -E vfp.c gives me
>
>   # 1 "vfp.c"
>   # 1 "<built-in>" 1
>   # 1 "<built-in>" 3
>   # 361 "<built-in>" 3
>   # 1 "<command line>" 1
>   # 1 "<built-in>" 2
>   # 1 "vfp.c" 2
>   1
>
>
> Unless I'm missing something a target of arm-linux-gnueabihf would define the macro unless the fpu were disabled with -mfpu=none so it should come through the test with the right answer.


Regarding the buildbot failure: the "armhf" sources list is populated from the "arm" sources list, and is the same as that. In the previous change, the VFP builtin sources were being excluded from the "arm" sources list earlier, resulting in them being excluded from the following "armhf" sources list as well. This was causing the tests related to those VFP sources to fail on the "armhf" builder.

> why you have excluded armhf from the MATCHES expression above

It shouldn't actually be excluded. When writing that if condition I assumed the VFP sources can always be included for armhf, which is wrong, as yes one can still disable fpu through -mfpu=none as part of the flags. I'll update the patch.


https://reviews.llvm.org/D47217