[PATCH] D49517: [WebAssembly] Handle return type conversions in FixFunctionBitcasts pass
Dan Gohman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jul 23 17:56:24 PDT 2018
sunfish added a comment.
In https://reviews.llvm.org/D49517#1172783, @sbc100 wrote:
> Interesting, so you are proposing delaying the error until link time but still producing a valid wasm binary?
Yeah. I don't always like delaying errors, but it sounds like that's what we need to make the CMake use case work, right? If so, I'm ok with that here.
> What about integer conversions? Sounds like you are saying they should also abort?
Yeah. Unless I'm missing something, this should be very rare in practice, and it's certainly undefined behavior, so hopefully it won't be important.
Repository:
rL LLVM
https://reviews.llvm.org/D49517
More information about the llvm-commits
mailing list