[PATCH] D49707: [tsan] Fix crash in objc_sync_enter/objc_sync_exit when using an Obj-C tagged pointer

[George Karpenkov via Phabricator via llvm-commits]

george.karpenkov added inline comments.


================
Comment at: lib/tsan/rtl/tsan_interceptors_mac.cc:299
+// contains data in the pointers bits instead)?
+bool IsTaggedPointer(void *obj) {
+  const uptr kPossibleTaggedBits = 0x8000000000000001ull;
----------------
also all the helper functions should be static


https://reviews.llvm.org/D49707