[PATCH] D49707: [tsan] Fix crash in objc_sync_enter/objc_sync_exit when using an Obj-C tagged pointer

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek added inline comments.


================
Comment at: lib/tsan/rtl/tsan_interceptors_mac.cc:303
+
+uptr SyncAddrForTaggedPointer(void *obj) {
+  (void)obj;
----------------
george.karpenkov wrote:
> what's the point of taking in the argument then?
The point is that, ideally, the function would return a different sync address for different pointers. But for now, the implementation trivially returns the same address for all, which can cause false negatives.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49707