[PATCH] D49707: [tsan] Fix crash in objc_sync_enter/objc_sync_exit when using an Obj-C tagged pointer

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubamracek created this revision.
kubamracek added reviewers: dvyukov, george.karpenkov, delcypher, dcoughlin.
kubamracek added a project: Sanitizers.
Herald added subscribers: Sanitizers, jfb.

Objective-C tagged pointers (either bottom-most or top-most bit is 1) are valid Obj-C objects but are not valid pointers. Make sure we don't crash on them when used in objc_sync_enter/objc_sync_exit. Instead, let's synchronize on a global object.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49707

Files:
  lib/tsan/rtl/tsan_interceptors_mac.cc
  test/tsan/Darwin/objc-synchronize-tagged.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49707.156925.patch
Type: text/x-patch
Size: 2922 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180723/ae78befd/attachment.bin>