[PATCH] D49147: Set Symbol::IsUsedInRegularObj in a consistent manor between COFF, ELF and wasm. NFC

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 16:24:12 PDT 2018


ruiu added inline comments.


================
Comment at: COFF/SymbolTable.h:112
+  std::pair<Symbol *, bool> insert(StringRef Name, InputFile *F);
   std::pair<Symbol *, bool> insert(StringRef Name);
   StringRef findByPrefix(StringRef Prefix);
----------------
Can you remove these single parameter version of `insert` by explicitly passing `nullptr` if the number of calls of that version is not too many?


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49147





More information about the llvm-commits mailing list