[PATCH] D49454: [DebugInfo] LowerDbgDeclare: Add derefs when handling CallInst users

[Vedant Kumar via Phabricator via llvm-commits]

vsk updated this revision to Diff 156915.
vsk edited the summary of this revision.
vsk added a comment.
Herald added subscribers: atanasyan, sdardis.
Herald added a reviewer: javed.absar.

This update fixes the long-standing issue where SelectionDAG was unable to distinguish between direct and indirect frame index debug values. Tackling this issue not only fixed the stack-var.c -O2 integration test from debuginfo-tests, but caught a slew of LLVM test cases which were checking for bogus DW_AT_locations.


https://reviews.llvm.org/D49454

Files:
  include/llvm/CodeGen/SelectionDAG.h
  include/llvm/IR/DebugInfoMetadata.h
  lib/CodeGen/SelectionDAG/InstrEmitter.cpp
  lib/CodeGen/SelectionDAG/SDNodeDbgValue.h
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  lib/IR/DebugInfoMetadata.cpp
  lib/Transforms/Utils/Local.cpp
  test/DebugInfo/AArch64/coalescing.ll
  test/DebugInfo/Mips/dsr-fixed-objects.ll
  test/DebugInfo/X86/bbjoin.ll
  test/DebugInfo/X86/dbg-value-const-byref.ll
  test/DebugInfo/X86/dbg-value-frame-index.ll
  test/DebugInfo/X86/debug-loc-frame.ll
  test/Transforms/InstCombine/lower-dbg-declare.ll
  unittests/IR/MetadataTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49454.156915.patch
Type: text/x-patch
Size: 28821 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180723/9a6215f7/attachment.bin>