[PATCH] D47208: [profile] Support profiling runtime on Fuchsia

[Roland McGrath via Phabricator via llvm-commits]

mcgrathr added inline comments.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c:19
+ * atexit hook to append its own data into the shared VMO which is published
+ * via the data sink hook provide by Fuchsia's dynamic linker.
+ */
----------------
typo: "provided"


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c:67
+    __sanitizer_publish_data(ProfileSinkName, Handle);
+  }
+
----------------
This should log a message including a sanitizer markup `dumpfile` element that refers to the VMO name.
Before that, it should set the VMO name.
See sanitizer_common/sanitizer_coverage_fuchsia.cc for an example.


================
Comment at: compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c:120
+    lprofWrite("Runtime and instrumentation version mismatch : "
+               "expected %d, but get %d\n",
+               INSTR_PROF_RAW_VERSION,
----------------
s/get/got/


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D47208