[PATCH] D49160: [WebAssembly] Added default stack-only instruction mode for MC.

[Wouter van Oortmerssen via Phabricator via llvm-commits]

aardappel marked 4 inline comments as done.
aardappel added inline comments.
Herald added a subscriber: jfb.


================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCTargetDesc.h:130
   case WebAssembly::ATOMIC_STORE8_I64:
+  case WebAssembly::ATOMIC_STORE8_I64_S:
     return 0;
----------------
aheejin wrote:
> `_S` opcodes for atomic stores have been added in D48992.
Thanks, rebased against that.


================
Comment at: test/CodeGen/WebAssembly/reg-stackify-stack.ll:16
 ; CHECK-LABEL: no0:
-; CHECK: return $1{{$}}
+; CHECK: return
 define i32 @no0(i32* %p, i32* %q) {
----------------
aheejin wrote:
> jgravelle-google wrote:
> > Probably worth the `{{$}}` on these two returns?
> FileCheck has `--match-full-lines` option that forces to match full lines, so maybe we can use that instead for new tests..?
Agreed, that would be simpler, especially since {{$}} is whitespace sensitive, and we have instructions that have whitespace in their output.


Repository:
  rL LLVM

https://reviews.llvm.org/D49160