[PATCH] D49397: Pass CMAKE_C_FLAGS to the custom libc++ build too

Azharuddin Mohammed via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 12:26:46 PDT 2018


azharudd added a comment.

In https://reviews.llvm.org/D49397#1166067, @phosek wrote:

> What about C++ flags? libc++ is a C++ library so those are likely going to be important as well. Rather than lumping both C and C++ flags together into a single variable, we should probably consider adding two new keyword arguments to `add_custom_libcxx`, `CMAKE_C_FLAGS` and `CMAKE_CXX_FLAGS`, and use those to pass C and C++ flags separately to libc++ build.


That sounds reasonable. Current code doesn't deal with any C or C++ specific flags -- its primarily the target arch flags. I'll update this to handle the C/C++ flags. Thanks.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D49397





More information about the llvm-commits mailing list