[PATCH] D49673: [AArch64] Add Tiny Code Model for AArch64

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 12:16:35 PDT 2018


efriedma added a comment.
Herald added a subscriber: jfb.

This seems mostly straightforward.

Is tiny supported with PIC?  Please add tests.

Do other in-tree targets correctly reject -code-model=tiny?



================
Comment at: lib/Target/AArch64/AArch64Subtarget.h:315
 
-  bool useSmallAddressing() const {
+  bool useSmallAddressing(bool OrTiny = false) const {
     switch (TLInfo.getTargetMachine().getCodeModel()) {
----------------
Please don't use an default parameter like this; just use two separate helpers instead.


https://reviews.llvm.org/D49673





More information about the llvm-commits mailing list