[PATCH] D49646: [COFF] Use comdat shared constants for MinGW as well

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 10:51:55 PDT 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Great, that makes sense now. These constants are regular old comdat constants. This makes us use the MSVC constant name mangling for now, but that's fine. The linker won't deduplicate constants between Clang and GCC, but that's not an ABI compatibility problem.


Repository:
  rL LLVM

https://reviews.llvm.org/D49646





More information about the llvm-commits mailing list