[PATCH] D49670: dwarfgen: Add support for generating the debug_str_offsets section

Pavel Labath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 23 07:53:55 PDT 2018


labath created this revision.
labath added reviewers: dblaikie, JDevlieghere, probinson.
Herald added a subscriber: aprantl.

The motivation for this is https://reviews.llvm.org/D49493, where we'd like to test details of
debug_str_offsets behavior which is difficult to trigger from a
traditional test.

This adds the plubming necessary for dwarfgen to generate this section.
The more interesting changes are:

- I've moved emitStringOffsetsTableHeader function from DwarfFile to DwarfStringPool, so I can generate the section header more easily from the unit test.
- added a new addAttribute overload taking an MCExpr*. This is used to generate the DW_AT_str_offsets_base, which links a compile unit to the offset table.

I've also added a basic test for reading and writing DW_form_strx forms.


Repository:
  rL LLVM

https://reviews.llvm.org/D49670

Files:
  lib/CodeGen/AsmPrinter/DwarfDebug.cpp
  lib/CodeGen/AsmPrinter/DwarfFile.cpp
  lib/CodeGen/AsmPrinter/DwarfStringPool.cpp
  lib/CodeGen/AsmPrinter/DwarfStringPool.h
  unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
  unittests/DebugInfo/DWARF/DwarfGenerator.cpp
  unittests/DebugInfo/DWARF/DwarfGenerator.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49670.156789.patch
Type: text/x-patch
Size: 11925 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180723/00fdbed0/attachment.bin>


More information about the llvm-commits mailing list