[PATCH] D49622: ELF: Make sections with KeepUnique bit eligible for ICF.

[ben via Phabricator via llvm-commits]

bd1976llvm added a comment.

Hi Peter,

Thanks for your address significance tables work!

Specific to this change:

I was under the impression that the intention of --keep-unique was to prevent *all* folding?

I found this open bug against gold that supports this interpretation: https://sourceware.org/bugzilla/show_bug.cgi?id=18865

If I --keep-unique a symbol it seems like I am asking for a strong guarantee on the address of the symbol. The original behaviour matches this strong guarantee.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D49622