[PATCH] D49651: [COFF] Fix assembly output of comdat sections without an attached symbol

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 22 13:36:01 PDT 2018


mstorsjo created this revision.
mstorsjo added reviewers: rnk, majnemer.

Since SVN r335286, the .xdata sections are produced without an attached symbol, which requires using a different syntax when  printing assembly output.

Instead of the usual syntax of '.section <name>,"dr",discard,<symbol>', use '.section <name>,"dr"' + '.linkonce discard' (which is what GCC uses for all assembly output).

This fixes PR38254.


Repository:
  rL LLVM

https://reviews.llvm.org/D49651

Files:
  lib/MC/MCSectionCOFF.cpp
  test/CodeGen/X86/mingw-comdats-xdata.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49651.156714.patch
Type: text/x-patch
Size: 4342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180722/57c8e64e/attachment.bin>


More information about the llvm-commits mailing list