[PATCH] D49630: [MS Demangler] Demangle data member pointers

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:252
+
+  // True if this is a member pointer.
+  Name *MemberName = nullptr;
----------------
s/True/Non-null/


================
Comment at: llvm/lib/Demangle/MicrosoftDemangle.cpp:594
+  // emit something like "int (*x)(int)".)
+  if (Pointee->Prim == PrimTy::Function || Pointee->Prim == PrimTy::Array)
+    OS << "(";
----------------
Nit: Might wanna factor this condition into a little helper to ensure that pre and post are consistent.


https://reviews.llvm.org/D49630