[PATCH] D49640: [ARM64][Windows] Create COMDAT symbols for sections containing constants

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

Funny coincidence that you post this now, I also just investigated the same issue, from a different point of view. Interestingly enough, LLD hasn't warned about it, otherwise I would have noticed much sooner.

But I'd suggest fixing this differently; since the code causing this is now in arch independent TargetLoweringObjectFileCOFF, we should also move this to an arch independent superclass, see https://reviews.llvm.org/D49644.

I'm also trying to fix this for ARM64 mingw, see https://reviews.llvm.org/D49637.



================
Comment at: test/CodeGen/AArch64/win_cst_pool.ll:1
+; RUN: llc < %s -mtriple=aarch64-windows-msvc | FileCheck %s
+
----------------
This new file shouldn't have executable mode


Repository:
  rL LLVM

https://reviews.llvm.org/D49640