[PATCH] D49626: ELF: Read address significance tables with --icf=all.

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 17:42:52 PDT 2018


pcc created this revision.
pcc added reviewers: ruiu, grimar, peter.smith.
Herald added subscribers: arichardson, emaste.
Herald added a reviewer: espindola.

Under --icf=all we now only apply KeepUnique to non-executable
address-significant sections. This has the effect of making --icf=all
mean unsafe ICF for executable sections and safe ICF for non-executable
sections.

With this change the meaning of the KeepUnique bit changes to
"does the current ICF mode (together with the --keep-unique and
--ignore-data-address-equality flags) require this section to be
kept unique".


https://reviews.llvm.org/D49626

Files:
  lld/ELF/Driver.cpp
  lld/ELF/ICF.cpp
  lld/test/ELF/icf-safe.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49626.156653.patch
Type: text/x-patch
Size: 8145 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180721/8b51f72f/attachment.bin>


More information about the llvm-commits mailing list