[PATCH] D49541: [ELF] - Implement SHT_SYMTAB_SHNDX (.symtab_shndxr) section.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SyntheticSections.cpp:1921
+static uint32_t getSymSectionIndex(Symbol *Sym) {
+  if (BssSection *CommonSec = getCommonSec(Sym))
+    return SHN_COMMON;
----------------
You are not using CommonSec.


================
Comment at: ELF/SyntheticSections.h:591
 
+class SymbolTableShndxSection final : public SyntheticSection {
+public:
----------------
I'd name this SymtabShndxSection for consistency with the name of the section.


https://reviews.llvm.org/D49541