[PATCH] D49016: [llvm-objdump] Add dynamic section printing to private-headers option

[Paul Semel via Phabricator via llvm-commits]

paulsemel added a comment.

Ok, I think the way I'm now getting the dynamic string table is good !

Hmm no.. I'm pretty sure it is a bad idea to do a PR that is completely relying on this one. I just duplicated the code, so I don't see any problem even if someone modifies this area in llvm-readobj. I will just refactor no worries :)



================
Comment at: tools/llvm-objdump/ELFDump.cpp:44
+template <class ELFT>
+Expected<StringRef> getDynamicStrTab(const ELFFile<ELFT> *o,
+                                     const typename ELFFile<ELFT>::Elf_Dyn *Dyn,
----------------
jhenderson wrote:
> jhenderson wrote:
> > o -> O (or probably better just Elf or similar, since it's not an object file if its got a dynamic section).
> Um... This hasn't been done?
Was for the function above, but I should have done this one too in the meantime !


Repository:
  rL LLVM

https://reviews.llvm.org/D49016