[compiler-rt] r337622 - Change the cap on the amount of padding for each vtable to 32-byte (previously it was 128-byte)

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 14:43:20 PDT 2018


Author: pcc
Date: Fri Jul 20 14:43:20 2018
New Revision: 337622

URL: http://llvm.org/viewvc/llvm-project?rev=337622&view=rev
Log:
Change the cap on the amount of padding for each vtable to 32-byte (previously it was 128-byte)

We tested different cap values with a recent commit of Chromium. Our results show that the 32-byte cap yields the smallest binary and all the caps yield similar performance.
Based on the results, we propose to change the cap value to 32-byte.

Patch by Zhaomo Yang!

Differential Revision: https://reviews.llvm.org/D49405

Modified:
    compiler-rt/trunk/test/cfi/create-derivers.test

Modified: compiler-rt/trunk/test/cfi/create-derivers.test
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/cfi/create-derivers.test?rev=337622&r1=337621&r2=337622&view=diff
==============================================================================
--- compiler-rt/trunk/test/cfi/create-derivers.test (original)
+++ compiler-rt/trunk/test/cfi/create-derivers.test Fri Jul 20 14:43:20 2018
@@ -7,15 +7,15 @@ B0: {{1B|B@@}}: {{.*}} size 1
 
 RUN: %clangxx_cfi -DB32 -flto -c -o %t2.o %S/simple-fail.cpp
 RUN: opt -lowertypetests -debug-only=lowertypetests -o /dev/null %t2.o 2>&1 | FileCheck --check-prefix=B32 %s
-B32: {{1B|B@@}}: {{.*}} size 24
+B32: {{1B|B@@}}: {{.*}} size 2{{3|4}}
 B32-NOT: all-ones
 
 RUN: %clangxx_cfi -DB64 -flto -c -o %t3.o %S/simple-fail.cpp
 RUN: opt -lowertypetests -debug-only=lowertypetests -o /dev/null %t3.o 2>&1 | FileCheck --check-prefix=B64 %s
-B64: {{1B|B@@}}: {{.*}} size 54
+B64: {{1B|B@@}}: {{.*}} size 5{{3|4}}
 B64-NOT: all-ones
 
 RUN: %clangxx_cfi -DBM -flto -c -o %t4.o %S/simple-fail.cpp
 RUN: opt -lowertypetests -debug-only=lowertypetests -o /dev/null %t4.o 2>&1 | FileCheck --check-prefix=BM %s
-BM: {{1B|B@@}}: {{.*}} size 84
+BM: {{1B|B@@}}: {{.*}} size 8{{3|4}}
 BM-NOT: all-ones




More information about the llvm-commits mailing list