[PATCH] D48283: [SCEV] Properly solve quadratic equations

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 14:36:04 PDT 2018


efriedma added inline comments.


================
Comment at: lib/Analysis/ScalarEvolution.cpp:10710
+      return UpperValid ? SE.getConstant(SU.getValue())
+                        : SE.getConstant(SL.getValue());
+
----------------
I'm not convinced this is correct: why is the "valid" solution guaranteed to be smaller?


Repository:
  rL LLVM

https://reviews.llvm.org/D48283





More information about the llvm-commits mailing list