[PATCH] D49425: [MemorySSAUpdater] Update Phi operands after trivial Phi elimination
George Burgess IV via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 20 14:05:39 PDT 2018
george.burgess.iv accepted this revision.
george.burgess.iv added a comment.
This revision is now accepted and ready to land.
LGTM after one nit is addressed. Thanks again!
================
Comment at: lib/Analysis/MemorySSAUpdater.cpp:90
+ // create a new one.
+ if (Phi && Phi->getNumOperands() != 0) {
+ // FIXME: Figure out whether this is dead code and if so remove it.
----------------
`Phi` should always be non-null now
https://reviews.llvm.org/D49425
More information about the llvm-commits
mailing list