[PATCH] D44357: [COFF] Adjust how we flag weak externals

Peter Collingbourne via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 13:43:42 PDT 2018


pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Object/COFFObjectFile.cpp:220
 
-  if (Symb.isWeakExternal()) {
+  if (const coff_aux_weak_external *awe = Symb.getWeakExternal()) {
     Result |= SymbolRef::SF_Weak;
----------------
nit: s/awe/AWE/g


https://reviews.llvm.org/D44357





More information about the llvm-commits mailing list