[PATCH] D49194: [WebAssembly] Add tests for weaker memory consistency orderings

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 13:42:50 PDT 2018


jfb added a comment.

In https://reviews.llvm.org/D49194#1170425, @sunfish wrote:

> For the record, I'm opposed to having the WebAssembly backend translate `asm volatile(""::: "memory")` differently from other targets in LLVM or GCC, which to my knowledge always translate it to a no-op, even on platforms with hardware fence instructions.


I think it should lower and not error out, and thought should be put into what it should lower to. No-op seems fine to me, but I'd like to hear a rationale.

This is the smallest of the issues I outline above.


Repository:
  rL LLVM

https://reviews.llvm.org/D49194





More information about the llvm-commits mailing list