[PATCH] D49328: [FileCheck] Provide an option for FileCheck to dump original input to stderr on failure

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In https://reviews.llvm.org/D49328#1170354, @george.karpenkov wrote:

> @dblaikie One thing where we could get unexpected behavior is when the environment variable is enabled, but the test does "not FileCheck",
>  thereby reversing the expected output.
>  However, I have only seen that done in `test/MC/Mips`, not in Clang at all, and arguably it's a bad design pattern with double negation,
>  where using `-NOT` directives was a way to go.


Yep, only FileCheck tests themselves should use 'not'. If you could check that these other tests pass with the feature enabled and fix any tests that aren't compatible with this feature, that'd be great!


Repository:
  rL LLVM

https://reviews.llvm.org/D49328