[PATCH] D49561: AMDGPU: Try to make isKnownNeverSNan more accurate

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 13:22:06 PDT 2018


arsenm added a comment.

>>> 4. UnsafeAlgebra includes NoNaNs and thus all of the above applies.
>> 
>> I do not agree with this. The per-instruction flags have decoupled the unsafe algebra properties from no-nans, and the per-function/global flags should follow suit.
> 
> OK, UnsafeAlgebra is probably not a right condition. FastMathFlags::isFast() definitely is.

Is fast is just all the flags enabled. No nans is just one bit of it


https://reviews.llvm.org/D49561





More information about the llvm-commits mailing list