[PATCH] D49328: [FileCheck] Provide an option for FileCheck to dump original input to stderr on failure
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 20 13:20:28 PDT 2018
dblaikie added a comment.
In https://reviews.llvm.org/D49328#1170336, @george.karpenkov wrote:
> @dblaikie done&done. Using `=false` or `=0` is sufficient to get the behavior you describe.
Sounds good. Please go ahead and commit this if you have commit access - otherwise let me know & I'll commit it for you.
Have you tested whether 'check-llvm' passes if a user is enabling this feature through the environment variable? (ie: they don't cause any accidental failures in FileCheck tests not expecting this output?) & also that enabling this feature via the environment variable does work - passing down through the build system, lit, etc (ie: inject a deliberate failure somewhere in LLVM & see if the failure prints out all the input)?
https://reviews.llvm.org/D49328
More information about the llvm-commits
mailing list