[PATCH] D49609: [isl] Typesafe user pointers

[Siddharth via Phabricator via llvm-commits]

bollu added inline comments.


================
Comment at: lib/Analysis/ScopInfo.cpp:1210
+  auto *SAI = NewArrayId.get_user<ScopArrayInfo *>();
   assert(SAI && "Must set a ScopArrayInfo");
 
----------------
bollu wrote:
> I believe this assert can be removed?
Ditto here. The assert was not removed. We don't need it anymore since `get_user` should check this?


================
Comment at: lib/CodeGen/IslAst.cpp:293
+      isl::manage_copy(Id).get_user<IslAstUserPayload *>();
   assert(Payload && "Post order visit assumes annotated for nodes");
 
----------------
bollu wrote:
> This assert can be removed?
I am confused, this assert still exists?


Repository:
  rPLO Polly

https://reviews.llvm.org/D49609