[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: include/clang/AST/Stmt.h:206
+    bool PartOfExplicitCast : 1;
+    unsigned BasePathSize : 32 - 6 - 1 - NumExprBits;
   };
----------------
rjmccall wrote:
> lebedev.ri wrote:
> > rjmccall wrote:
> > > This needs to be serialized.
> > Uhm, could you please explain what do you mean by 'serialized'?
> It needs to be preserved when writing an ICE into a PCH / module file.  See the ASTWriter / ASTReader.
Aha. I did add handling there but it raises questions:
  #  This will silently break with different AST serialization versions.
     I'm not sure how to handle it, since `VERSION_MINOR` isn't even read back.
  #  //Does// this need a test? How to write one?
     Like `./test/PCH/include-timestamp.cpp`, using `llvm-bcanalyzer`?


Repository:
  rC Clang

https://reviews.llvm.org/D49508