[PATCH] D49607: [ELF] Check eh_frame_hdr overflow with PC offsets instead of PC absolute addresses
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 20 12:33:49 PDT 2018
MaskRay marked 2 inline comments as done.
MaskRay added inline comments.
================
Comment at: ELF/SyntheticSections.cpp:513
+ Twine::utohexstr(Pc - VA));
uint32_t FdeVA = getParent()->Addr + Fde->OutputOff;
+ Ret.push_back({Pc, FdeVA});
----------------
ruiu wrote:
> Can't FdeVA overflow?
```
uint32_t Pc -> uint64_t PcRel
uint32_t FdeVA -> uint64_t FdeVARel
```
Repository:
rLLD LLVM Linker
https://reviews.llvm.org/D49607
More information about the llvm-commits
mailing list