[llvm] r329470 - [Support] Make line-number cache robust against access patterns.

Graydon Hoare via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 12:13:23 PDT 2018


No, this is a tautological comparison at this point (at least until we have 128-bit size_t platforms) added without thinking about the tautological-comparison warning, my mistake. It should be removed (I was going to get to it soon but am still working through vacation backlog; if you want to beat me to it, go for it).

-Graydon

> On Jul. 16, 2018, at 1:43 a.m., Joerg Sonnenberger <joerg at bec.de> wrote:
> 
> On Sat, Apr 07, 2018 at 12:44:02AM -0000, Graydon Hoare via llvm-commits wrote:
>> Author: graydon
>> Date: Fri Apr  6 17:44:02 2018
>> New Revision: 329470
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=329470&view=rev
>> Log:
>> [Support] Make line-number cache robust against access patterns.
> 
> Does assert(Sz <= std::numeric_limits<uint64_t>::max()) serve a purpose?
> It breaks a build with -Werror on 32bit platforms.
> 
> Joerg



More information about the llvm-commits mailing list