[PATCH] D49508: [Sema] Mark implicitly-inserted ICE's as being part of explicit cast (PR38166)

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 20 11:09:52 PDT 2018


rjmccall added inline comments.


================
Comment at: include/clang/AST/Stmt.h:205
     unsigned Kind : 6;
-    unsigned BasePathSize : 32 - 6 - NumExprBits;
+    bool PartOfExplicitCast : 1;
+    unsigned BasePathSize : 32 - 6 - 1 - NumExprBits;
----------------
This needs to be `unsigned` to pack optimally on MSVC.


================
Comment at: include/clang/AST/Stmt.h:206
+    bool PartOfExplicitCast : 1;
+    unsigned BasePathSize : 32 - 6 - 1 - NumExprBits;
   };
----------------
This needs to be serialized.


Repository:
  rC Clang

https://reviews.llvm.org/D49508





More information about the llvm-commits mailing list