[PATCH] D49569: [X86] Remove what appear to be unnecessary uses of DCI.CombineTo
Phabricator via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 20 11:03:14 PDT 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL337589: [X86] Remove what appear to be unnecessary uses of DCI.CombineTo (authored by ctopper, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D49569?vs=156363&id=156546#toc
Repository:
rL LLVM
https://reviews.llvm.org/D49569
Files:
llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
Index: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
===================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
@@ -30830,7 +30830,7 @@
// Nuke no-op shuffles that show up after combining.
if (isNoopShuffleMask(Mask))
- return DCI.CombineTo(N.getNode(), N.getOperand(0), /*AddTo*/ true);
+ return N.getOperand(0);
// Look for simplifications involving one or two shuffle instructions.
SDValue V = N.getOperand(0);
@@ -31286,9 +31286,8 @@
// a particular chain.
if (SDValue Res = combineX86ShufflesRecursively(
{Op}, 0, Op, {0}, {}, /*Depth*/ 1,
- /*HasVarMask*/ false, DAG, Subtarget)) {
- return DCI.CombineTo(N, Res);
- }
+ /*HasVarMask*/ false, DAG, Subtarget))
+ return Res;
}
return SDValue();
@@ -34259,9 +34258,8 @@
SDValue Op(N, 0);
if (SDValue Res =
combineX86ShufflesRecursively({Op}, 0, Op, {0}, {}, /*Depth*/ 1,
- /*HasVarMask*/ false, DAG, Subtarget)) {
- return DCI.CombineTo(N, Res);
- }
+ /*HasVarMask*/ false, DAG, Subtarget))
+ return Res;
return SDValue();
}
@@ -34320,9 +34318,8 @@
SDValue Op(N, 0);
if (SDValue Res = combineX86ShufflesRecursively(
{Op}, 0, Op, {0}, {}, /*Depth*/ 1,
- /*HasVarMask*/ false, DAG, Subtarget)) {
- return DCI.CombineTo(N, Res);
- }
+ /*HasVarMask*/ false, DAG, Subtarget))
+ return Res;
}
// Constant Folding.
@@ -34360,9 +34357,8 @@
SDValue Op(N, 0);
if (SDValue Res =
combineX86ShufflesRecursively({Op}, 0, Op, {0}, {}, /*Depth*/ 1,
- /*HasVarMask*/ false, DAG, Subtarget)) {
- return DCI.CombineTo(N, Res);
- }
+ /*HasVarMask*/ false, DAG, Subtarget))
+ return Res;
return SDValue();
}
@@ -34816,9 +34812,8 @@
SDValue Op(N, 0);
if (SDValue Res = combineX86ShufflesRecursively(
{Op}, 0, Op, {0}, {}, /*Depth*/ 1,
- /*HasVarMask*/ false, DAG, Subtarget)) {
- return DCI.CombineTo(N, Res);
- }
+ /*HasVarMask*/ false, DAG, Subtarget))
+ return Res;
}
// Attempt to combine a scalar bitmask AND with an extracted shuffle.
@@ -37226,9 +37221,8 @@
SDValue Op(N, 0);
if (SDValue Res = combineX86ShufflesRecursively(
{Op}, 0, Op, {0}, {}, /*Depth*/ 1,
- /*HasVarMask*/ false, DAG, Subtarget)) {
- return DCI.CombineTo(N, Res);
- }
+ /*HasVarMask*/ false, DAG, Subtarget))
+ return Res;
}
return SDValue();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49569.156546.patch
Type: text/x-patch
Size: 2763 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180720/d6f68416/attachment.bin>
More information about the llvm-commits
mailing list