[PATCH] D48986: [FileCheck] Fix search ranges for DAG-NOT-DAG

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

Sorry, lost track of this one.  One comment suggestion and LGTM.



================
Comment at: llvm/utils/FileCheck/FileCheck.cpp:1299
+  for (auto PatItr = DagNotStrings.begin(), PatEnd = DagNotStrings.end();
+       PatItr != PatEnd; ++PatItr) {
+    const Pattern &Pat = *PatItr;
----------------
Range-based for loops are now so canonical, you should have a comment explaining why this isn't.  Especially because the reason is pretty far away in the source.


https://reviews.llvm.org/D48986