[PATCH] D49434: Put "built-in" function definitions in global Used list, for LTO. (fix bug 34169)

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: lib/Object/IRSymtab.cpp:237
+
+  // FIXME:  This fixes the issue with builtin functions being
+  // internalized (and later dead-code-eliminated) in the new LTO
----------------
pcc wrote:
> I don't think we need this FIXME. As far as I know, this problem is already "solved" in the old LTO API by the client providing an appropriate preserve list.
I disagree regarding the old LTO API - just as we are solving it here for all clients of the new LTO API, I think it would be nice to be consistent and user-friendly to solve it in a similar way in the old LTO API. However, I don't believe the FIXME belongs here. I would just move it to the new test case above the llvm-lto line that has the commented out llvm-nm check.


https://reviews.llvm.org/D49434