[PATCH] D49575: Merge demangler changes over to libcxxabi

[Zachary Turner via llvm-commits]

Or just doing nothing. It’s a private header and is only included in 1 TU.
In that fine, cxxabi-config is already included first
On Fri, Jul 20, 2018 at 5:20 AM Nico Weber via Phabricator <
reviews at reviews.llvm.org> wrote:

> thakis added inline comments.
>
>
> ================
> Comment at: libcxxabi/src/demangle/Compiler.h:23
> +#ifndef NDEBUG
> +#if __has_attribute(noinline) && __has_attribute(used)
> +#define DUMP_METHOD __attribute__((noinline, used))
> ----------------
> erik.pilkington wrote:
> > This depends on `__cxxabi_config.h` to make sure that `__has_attribute`
> is defined on compilers that don't support it. Please add the include.
> Is there any harm to just #ifndef #def here instead of pulling in that
> whole header?
>
>
> https://reviews.llvm.org/D49575
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180720/af162097/attachment.html>