[PATCH] D49596: [Support] Add a UniqueStringSaver: like StringSaver, but deduplicating.

[Sam McCall via Phabricator via llvm-commits]

sammccall created this revision.
sammccall added a reviewer: hokein.
Herald added a subscriber: llvm-commits.

Clarify contract of StringSaver (it null-terminates, callers rely on it).


Repository:
  rL LLVM

https://reviews.llvm.org/D49596

Files:
  include/llvm/Support/StringSaver.h
  lib/Support/StringSaver.cpp


Index: lib/Support/StringSaver.cpp
===================================================================
--- lib/Support/StringSaver.cpp
+++ lib/Support/StringSaver.cpp
@@ -17,3 +17,13 @@
   P[S.size()] = '\0';
   return StringRef(P, S.size());
 }
+
+StringRef UniqueStringSaver::save(StringRef S) {
+  auto It = Unique.find(S);
+  if (It != Unique.end())
+    return *It;
+  S = Strings.save(S);
+  if (!Unique.insert(S).second)
+    llvm_unreachable("Failed to insert into unique table - race?");
+  return S;
+}
Index: include/llvm/Support/StringSaver.h
===================================================================
--- include/llvm/Support/StringSaver.h
+++ include/llvm/Support/StringSaver.h
@@ -10,23 +10,49 @@
 #ifndef LLVM_SUPPORT_STRINGSAVER_H
 #define LLVM_SUPPORT_STRINGSAVER_H
 
+#include "llvm/ADT/DenseSet.h"
 #include "llvm/ADT/StringRef.h"
 #include "llvm/ADT/Twine.h"
 #include "llvm/Support/Allocator.h"
 
 namespace llvm {
 
-/// Saves strings in the inheritor's stable storage and returns a
+/// Saves strings in the provided stable storage and returns a
 /// StringRef with a stable character pointer.
 class StringSaver final {
   BumpPtrAllocator &Alloc;
 
 public:
   StringSaver(BumpPtrAllocator &Alloc) : Alloc(Alloc) {}
+
+  // All returned strings are null-terminated: *save(S).end() == 0.
   StringRef save(const char *S) { return save(StringRef(S)); }
   StringRef save(StringRef S);
   StringRef save(const Twine &S) { return save(StringRef(S.str())); }
   StringRef save(const std::string &S) { return save(StringRef(S)); }
 };
+
+/// Saves strings in the provided stable storage and returns a StringRef with a
+/// stable character pointer. Saving the same string yields the same StringRef.
+///
+/// Compared to StringSaver, it does more work but avoids saving the same string
+/// multiple times.
+///
+/// Compared to StringPool, it performs fewer allocations but doesn't support
+/// refcounting/deletion.
+class UniqueStringSaver final {
+  StringSaver Strings;
+  llvm::DenseSet<llvm::StringRef> Unique;
+
+public:
+  UniqueStringSaver(BumpPtrAllocator &Alloc) : Strings(Alloc) {}
+
+  // All returned strings are null-terminated: *save(S).end() == 0.
+  StringRef save(const char *S) { return save(StringRef(S)); }
+  StringRef save(StringRef S);
+  StringRef save(const Twine &S) { return save(StringRef(S.str())); }
+  StringRef save(const std::string &S) { return save(StringRef(S)); }
+};
+
 }
 #endif


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49596.156476.patch
Type: text/x-patch
Size: 2450 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180720/aa7d244a/attachment.bin>