[PATCH] D49472: [WIP] Always create a MCFragment for Mach-O section.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked an inline comment as done.
JDevlieghere added inline comments.


================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:955-957
+    return Ctx->getMachOSection("__DWARF", "__debug_types", MachO::S_ATTR_DEBUG,
+                                SectionKind::getMetadata(),
+                                "debug_types_begin");
----------------
dblaikie wrote:
> How does this section get deduplicated by the linker? (I don't see the 'Hash' being used here, which is the unique key for the section)
I can only speak for Darwin, but the linker just ignores debug info. We have dsymutil for deduplication. 


================
Comment at: llvm/lib/MC/MCObjectFileInfo.cpp:969
+  case Triple::Wasm:
+    return Ctx->getWasmSection(".debug_info", SectionKind::getMetadata());
+  case Triple::UnknownObjectFormat:
----------------
dblaikie wrote:
> I assume this is incorrect (given that this function is for the debug_types section (& should be comdat or equivalent) rather than debug_info)?
Yup, this is a typo


https://reviews.llvm.org/D49472