[PATCH] D49557: [ELF] Fix handling of FDE negative relative PC addr
Andrew Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Jul 20 02:47:10 PDT 2018
andrewng added a comment.
In https://reviews.llvm.org/D49557#1168549, @ruiu wrote:
> Thanks! How did yoy find this?
Our LLD port uses linker scripts where .eh_frame is placed after .text, so a number of our test cases started failing with the "PC address is too large" error from commit 8a1ed003. That led me to finding this issue.
In https://reviews.llvm.org/D49557#1169389, @grimar wrote:
> Also, what about adding 3 test cases? A one for each new type you added (DW_EH_PE_sdata2, DW_EH_PE_sdata4, DW_EH_PE_sdata8).
Yes, that's a good idea, although having had a quick look, I'm not too sure we have test coverage for all the other types either. Also I think some of the .eh_frame value format tests are using invalid augmentation strings, but these issues aren't related to this particular patch.
https://reviews.llvm.org/D49557
More information about the llvm-commits
mailing list